Shivaraj B H (Dec 22 2023 at 06:17): Shivaraj B H (Dec 22 2023 at 06:17):@Rohit Singh Now that the <name>-init process doesn't run before <name> process (here <name> is a postgres server), i.e after this PR, we have to rename <name>-init to something more appropriate. What can this be? I am thinking <name>-postStart, but that doesn't capture the essence of its task, which is running a bunch of .sql dumps or plain text SQL scripts given by initialScript option.
Shivaraj B H (Dec 22 2023 at 06:20):How about <name>-postScript?
Rohit Singh (Dec 22 2023 at 06:30):Shivaraj B H said:
How about
<name>-postScript?
How about <name>-postStartScript ?
Because post does not actually describes post what ? So if we keep postStartScript that would mean post starting the postgres server.
Shivaraj B H (Dec 22 2023 at 06:41):Let's go with postStartScript for now. Let's wait until tomorrow for any suggestions and merge it.
Shivaraj B H (Dec 22 2023 at 07:51):Let’s not forget the fact that the script only runs once, i.e if the dataDir is not already present, so we could consider initialPostStartScript too
Shivaraj B H (Dec 23 2023 at 16:17):I think it would be better if we stick to init process running before the postgres server process, we can use pg_ctl to start and stop the server during initialisation as does devenv.
Shivaraj B H (Dec 23 2023 at 16:18):I have updated the PR, check the link in the first message of this topic.
Shivaraj B H (Dec 24 2023 at 03:14):Also see the updated description of the PR for the key changes.
Notification Bot (Dec 28 2023 at 20:32):Shivaraj B H has marked this topic as resolved.
Last updated: Nov 15 2024 at 12:33 UTC